Repository navigation
chore: update favicon to the current Solid logo - #1718
Merged
Merged
Conversation
The favicon was still the old gradient logo. Use the flat icons from solidjs.com, with the light and dark variants it uses, and rebuild favicon.ico (16/32/48) from the new logo. Co-authored-by: Claude <noreply@anthropic.com>
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
brenelz
approved these changes
Nov 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
The docs favicon was still the old gradient Solid logo, while solidjs.com uses the new flat logo.
public/favicon.icoandpublic/favicon.svgwere last changed in early 2024.This PR switches to the same icons solidjs.com serves:
public/favicon.svg: the flat light icon (solid-icon-flat-light.svgfrom solidjs.com).public/favicon-dark.svg(new): the flat dark icon (solid-icon-flat-dark.svg).public/favicon.ico: rebuilt from the new logo at 16, 32 and 48 px (PNG-in-ICO), for browsers that don't use SVG favicons. The old file was a single 16×16 PNG.src/entry-server.tsx: links both SVGs asrel="icon"withprefers-color-schememedia queries, as solidjs.com does. The.icogetssizes="48x48"so browsers that support SVG pick the SVG over it. The SVG was previously linked asrel="alternate icon", so browsers used the.ico.#008EDCflat logo#0AA0EFflat logoHow I checked: the
.icorenders cleanly at 16 and 48 px, and the files pass Prettier. I haven't run the site locally to look at the browser tab.Related issues & labels
Drafted with Claude via OpenCode.